gh-118469: Document sqlite3 PEP-249 constructors#118975
gh-118469: Document sqlite3 PEP-249 constructors#118975firatv wants to merge 5 commits intopython:mainfrom
Conversation
erlend-aasland
left a comment
There was a problem hiding this comment.
Thanks for the PR! I don't think we should expose implementation details; instead, try to (re)use the wording of PEP-249 (or adapt it to fit within the sqlite3 docs).
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
No response for more than two months. Applied the |
|
There is also a competing PR up: |
|
I apologise for not being around for so long. I checked the preview, seems like everything is set. I assume I should close this PR. Thank you all for your time, attention and efforts. Also, sorry again. |
📚 Documentation preview 📚: https://cpython-previews--118975.org.readthedocs.build/