Small change: Delete obsolete comment from copyreg.py#116225
Open
rodrigodesalvobraz wants to merge 2 commits intopython:mainfrom
Open
Small change: Delete obsolete comment from copyreg.py#116225rodrigodesalvobraz wants to merge 2 commits intopython:mainfrom
rodrigodesalvobraz wants to merge 2 commits intopython:mainfrom
Conversation
A comment states that copyreg is only useful for C objects, not for user-defined classes, which is at odds with its documentation. See more at https://stackoverflow.com/q/78087188/3358488
Small change: Delete out of the data comment from copyreg.py
This comment was marked as resolved.
This comment was marked as resolved.
davidlowryduda
approved these changes
Mar 19, 2024
Contributor
davidlowryduda
left a comment
davidlowryduda
left a comment
There was a problem hiding this comment.
Removing this comment makes sense. It seems to be a leftover from a much older version of python and directly contradicts the current documentation.
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment states that copyreg is only useful for C objects, not for user-defined classes, which is at odds with its documentation.
See more at https://stackoverflow.com/q/78087188/3358488