Skip to content

gh-115997: Make HTTPResponse.read1 and readline raise IncompleteRead#115998

Open
illia-v wants to merge 14 commits intopython:mainfrom
illia-v:gh-115997
Open

gh-115997: Make HTTPResponse.read1 and readline raise IncompleteRead#115998
illia-v wants to merge 14 commits intopython:mainfrom
illia-v:gh-115997

Conversation

@illia-v
Copy link
Copy Markdown
Contributor

@illia-v illia-v commented Feb 27, 2024 •
edited by bedevere-app Bot
Loading

@bedevere-app bedevere-app Bot mentioned this pull request Feb 27, 2024
Open
@illia-v
Copy link
Copy Markdown
Contributor Author

illia-v commented Mar 27, 2024

@serhiy-storchaka could you please take a look at this PR? It's similar to #113199

vadmium
vadmium reviewed Jan 31, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vadmium vadmium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current changes would be better than nothing, but I hope my suggestion would also fix the case of readline with an incomplete line

Comment thread Lib/http/client.py Outdated
Comment thread Lib/http/client.py
@illia-v
Copy link
Copy Markdown
Contributor Author

illia-v commented Feb 10, 2025

Current changes would be better than nothing, but I hope my suggestion would also fix the case of readline with an incomplete line

@vadmium please check if my last changes fix the case

@illia-v illia-v requested a review from vadmium February 10, 2025 21:09
vadmium
vadmium reviewed Mar 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vadmium vadmium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only looked at the changes, not tried running them. They look worthwhile to me, although there is room for improving the tests.

Comment thread Lib/test/test_httplib.py
Comment thread Lib/test/test_httplib.py Outdated
@illia-v illia-v requested a review from vadmium April 1, 2025 17:49
@vadmium
Copy link
Copy Markdown
Member

vadmium commented Apr 1, 2025

Looks okay to me

@illia-v
Copy link
Copy Markdown
Contributor Author

illia-v commented Apr 2, 2025

Looks okay to me

@vadmium thank you for the review! Do you think it can be merged before 3.14's betas?

@illia-v illia-v mentioned this pull request Feb 13, 2026
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadmium vadmium Awaiting requested review from vadmium

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@illia-v @vadmium