Fix autofix checkpoint placement in except clauses#442
Merged
Zac-HD merged 2 commits intopython-trio:mainfrom Apr 20, 2026
Merged
Fix autofix checkpoint placement in except clauses#442Zac-HD merged 2 commits intopython-trio:mainfrom
Zac-HD merged 2 commits intopython-trio:mainfrom
Conversation
The autofix for missing checkpoints (ASYNC910/ASYNC911) used to insert `await ...checkpoint()` right before the offending return/yield, which would be inside an except handler and trigger ASYNC120. Detect that case and redirect the insertion to the top of the innermost enclosing loop (if any) or to the top of the function body instead. Fall back to the previous location only for contorted cases where neither of those safer locations would actually break the uncheckpointed path. Fixes python-trio#403.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autofix for missing checkpoints (ASYNC910/ASYNC911) used to insert
await ...checkpoint()right before the offending return/yield, which would be inside an except handler and trigger ASYNC120. Detect that case and redirect the insertion to the top of the innermost enclosing loop (if any) or to the top of the function body instead. Fall back to the previous location only for contorted cases where neither of those safer locations would actually break the uncheckpointed path.Fixes #403.