Use pathlib.Path to find test images and fonts - #10079
Merged
Merged
Conversation
hugovk
reviewed
Sep 29, 2026
akx
force-pushed
the
fuzz-subprocess
branch
from
September 29, 2026 07:21
dd756fb to
b2e4d6b
Compare
Member
|
My instinct would be to put the new functions in test_fuzzers.py, rather than in helpers.py? They are only used there, and it is unlikely that we'd find another purpose for them. |
Contributor
Author
Sure thing. |
akx
force-pushed
the
fuzz-subprocess
branch
from
September 29, 2026 08:29
b2e4d6b to
bbefd99
Compare
Contributor
Author
|
Inlined into |
hugovk
reviewed
Sep 29, 2026
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
akx
force-pushed
the
fuzz-subprocess
branch
from
September 29, 2026 12:36
bbefd99 to
8ea91dd
Compare
hugovk
approved these changes
Sep 29, 2026
akx
force-pushed
the
fuzz-subprocess
branch
from
September 29, 2026 12:54
a95eb29 to
eaf5e77
Compare
Contributor
Author
|
Btw, speaking of I could do that cleanup, but are there maintainer opinions about how aggressively e.g. Something like akx@dab74b9 but a wider sweep. |
radarhere
reviewed
Sep 29, 2026
akx
force-pushed
the
fuzz-subprocess
branch
from
September 29, 2026 13:00
eaf5e77 to
ab5234c
Compare
radarhere
enabled auto-merge (squash)
September 29, 2026 13:08
subprocess to find test images and fontspathlib.Path to find test images and fonts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just something I noticed. Felt a little silly to spawn a shell and
findwhenrglobdoes the trick.