Add decompression bomb check to grabclipboard() on Windows - #10078
Merged
Merged
Conversation
akx
approved these changes
Sep 29, 2026
akx
left a comment
Contributor
There was a problem hiding this comment.
LGTM. A couple of comment suggestions to make the life of future reviewers a bit easier?
| UINT format; | ||
| UINT formats[] = {CF_DIB, CF_DIBV5, CF_HDROP, RegisterClipboardFormatA("PNG"), 0}; | ||
| LPCSTR format_names[] = {"DIB", "DIB", "file", "png", NULL}; | ||
| LPCSTR format_names[] = {"DIB", "DIB", "file", "PNG", NULL}; |
Contributor
There was a problem hiding this comment.
Suggested change
| LPCSTR format_names[] = {"DIB", "DIB", "file", "PNG", NULL}; | |
| // Pillow format names in the same order as the formats above | |
| LPCSTR format_names[] = {"DIB", "DIB", "file", "PNG", NULL}; |
Member
Author
There was a problem hiding this comment.
...they're not exactly 'Pillow format names'. 'DIB' and 'PNG are, but 'file' isn't.
Contributor
There was a problem hiding this comment.
Fair:
Suggested change
| LPCSTR format_names[] = {"DIB", "DIB", "file", "PNG", NULL}; | |
| // Names known by ImageGrab.py in the same order as the formats above | |
| LPCSTR format_names[] = {"DIB", "DIB", "file", "PNG", NULL}; |
Member
Author
There was a problem hiding this comment.
I've pushed a similar comment, that connects it clearly to the variable in ImageGrab.py.
hugovk
approved these changes
Sep 29, 2026
Co-authored-by: Aarni Koskela <akx@iki.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment,
grabclipboard()on Windows may bypassImage.open()when loading the image data.Pillow/src/PIL/ImageGrab.py
Lines 184 to 192 in 7cb0e02
This means that they avoid running
Pillow/src/PIL/Image.py
Line 3687 in 7cb0e02
Switching to
Image.open()adds this check.