Conversation
akx
reviewed
Sep 28, 2026
akx
left a comment
akx
left a comment
Contributor
There was a problem hiding this comment.
Beyond the inline comments, I guess it would be nice to also add C doc comments explaining the retval and who's responsible for freeing the image on error?
| imOut = ImagingNewDirty(imIn->mode, xsize, ysize); | ||
|
|
||
| imOut = ImagingTransform( | ||
| ImagingTransform( |
Contributor
There was a problem hiding this comment.
Should there be an error check here?
| @@ -883,7 +886,8 @@ ImagingScaleAffine( | |||
| xintab = (int *)calloc(out_xsize, sizeof(int)); | |||
| if (!xintab) { | |||
| ImagingDelete(imOut); | |||
Contributor
There was a problem hiding this comment.
So... whose responsibility it is to delete imOut? 🤔 The above error returns do not delete it, this does?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pillow/src/_imaging.c
Lines 2170 to 2180 in 38c17ed
This looks odd to me, because
imOutis checked for an error, but even if there is no error, it is discarded?The reason is that
ImagingTransform()is actually passing back the first argument asimOuton success, andNULLon failure.I think it would be clearer to return 0 on success, and -1 on failure.