Add some benchmarks for ImageMath - #10071
Merged
Merged
Conversation
akx
marked this pull request as ready for review
September 28, 2026 07:19
hugovk
approved these changes
Sep 28, 2026
radarhere
reviewed
Sep 28, 2026
| a = make_pillow_image(mode, size) | ||
| bench.extra_info["label"] = [f"scalar mul {mode}"] | ||
| result = bench(ImageMath.lambda_eval, lambda args: args["a"] * 2, a=a) | ||
| assert result.size == a.size |
Member
There was a problem hiding this comment.
Why isn't this just another parameter on test_imagemath_unary?
pytest.param(lambda a: a * 2, id=...),
Member
There was a problem hiding this comment.
You requested my review again, so I think you missed this comment.
Contributor
Author
There was a problem hiding this comment.
Sorry, yeah, I did. It's not an unary operation in _imagingmath terms, it's a special case of binary operations.
As noted in the PR description for #10072, the binary operation with one scalar operand case could use its own class of optimizations.
radarhere
reviewed
Sep 28, 2026
radarhere
reviewed
Sep 28, 2026
radarhere
reviewed
Sep 28, 2026
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows in the footsteps of #10033 being broken out of #10030: I'm working on speeding up ImageMath too, but with this we'll get some benchmarks on
main:)