Repository navigation
Conversation
Automation signalsActivity patterns show signs of automation. Evidence
This is an automated analysis by AgentScan |
Contributor
|
We have repeatedly rejected near-identical patches. Please read the issue discussion. I'm closing this on the grounds that it appears to be fully automated activity, and as such a violation of our project policy. There is an appropriate fix; this is not it and this type of PR is actively harmful. |
Member
|
Again? That issue starts being a true indicator for slop.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--newline=preserveruns after resolving dependencies,_determine_linesepiterates over(output_file.name, *src_files)and opens each file in binary mode to detect whether\r\nor\nis present.If the input is a named pipe/FIFO (or output is stdout
-), this re-opens the pipe for reading. Since the pipe was already drained while reading requirements during resolution, opening it again blocks indefinitely waiting for another writer (issue #2232). It also means a literal file named-in cwd would accidentally get read as standard output.We skip
fname == "-"and any path wherenot os.path.isfile(fname)so FIFOs, character devices, and standard streams aren't re-opened. Also broadened theFileNotFoundErrorcatch toOSErrorso permission issues or broken descriptors don't crash linesep detection.Fixes #2232.
Contributor checklist
changelog.d/(seechangelog.d/README.mdfor instructions) or the PR text says "no changelog needed".
Maintainer checklist
bot:chronographer:skiplabel.(following Semantic Versioning).