Fix env var formatting in get_env_var() function - #2397
Open
valentinoli wants to merge 7 commits into
Open
Conversation
Contributor
Author
|
@cjames23 can you please review this bug fix? |
Contributor
Author
|
@cjames23 I would appreciate if this gets fixed soon as variables containing a dash are currently not made available in Hatch For instance, the below variable is not exposed: [tool.hatch.envs.default.env-vars]
"HATCH_ENV_TYPE_PIP-COMPILE_UV_PATH" = "{root:real}/scripts/uv" |
Member
|
@valentinoli I will look at this when I have some free time. Keep in mind that Ofek and I both do this outside of our regular jobs so we might not be looking every single day at PRs and issues created |
Contributor
Author
I completely understand, take your time as always and thank you for your dedication to this project. <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLUGIN_NAMEmight contain dashes, for examplepip-compile. This PR replaces dashes with underscores in the plugin name when formatting the environment variable for a Hatch environment option.Closes #2402