fix: expand recursive extras manually, normalize extra names - #2381
Open
flying-sheep wants to merge 1 commit into
Open
fix: expand recursive extras manually, normalize extra names#2381flying-sheep wants to merge 1 commit into
flying-sheep wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m tired. Complete whack-a-mole …
This once again fixes regressions caused by a previous fix (this time both are mine).
It also fixes a latent bug around extra name normalization.
This is still not the ideal state. For that, we could resolve in
Project.get_dependencies(), so Hatch has exactly one place that turns rawoptional-dependenciesinto resolved ones, andall_dependencies_complexjust consumes it. There are a bunch of callers though, so we shouldn’t do it as part of this bugfix.