Some type fixes - #1138
Open
flying-sheep wants to merge 11 commits into
Open
Conversation
Member
Author
|
@ofek what do you think? |
Member
|
@flying-sheep can you rebase this so we can review it? Or otherwise I can close it out. |
Member
Author
|
done |
Member
|
@flying-sheep looks like there is a type-ignore that is no longer needed from these changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProjectMetadatais generic over thePluginManager, so things holding it should be too.While adding a parameter to
BuildHookInterfaceis a breaking change (Python should support optional named type parameters like TypeScript to avoid that),BuilderInterfaceis an especially low hanging fruit, as it is already generic overPluginManagerBound, so my changes to it just surface things that are already true.One kinda unrelated change is that
get_version_api’s documentation seems wrong.build_dataseems to be**kwargs, not a single parameter.There might be other classes to fix, but I only encountered those two so far.