Repository navigation
sdist: match dotfiles in file pattern globbing - #828
Open
DYNOSuprovo wants to merge 1 commit into
Open
DYNOSuprovo wants to merge 1 commit into
DYNOSuprovo wants to merge 1 commit into
Conversation
Switch FilePatterns globbing in flit_core to use Path.glob so that recursive patterns like **/*.swp correctly match hidden dotfiles. Normalize pattern syntax for pathlib compatibility and update default sdist exclude **.pyc to **/*.pyc. Signed-off-by: DYNOSuprovo <DYNOSuprovo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #746
Problem
When configuring sdist exclude patterns like
exclude = ["**/*.swp"], standardglob.globignores hidden files (filenames beginning with., such as.foo.swpcreated by editors like Vim) by default. As a result, those files remain included in sdist builds or cause untracked file errors during VCS checks.Solution
FilePatternsinflit_core.sdistto expand patterns usingpathlib.Path.glob, which matches hidden dotfiles across all supported Python versions.**.extto**/*.ext).config.pyfrom**.pycto**/*.pyc.flit_core/tests_core/test_sdist.pyverifying that recursive glob patterns properly match and exclude dotfiles inFilePatternsandSdistBuilder.