Skip to content

fix: improve com table display - #560

Merged
tlambert03 merged 1 commit into
pymmcore-plus:mainfrom
gselzer:com-table-visibility
Jul 19, 2026
Merged

tlambert03 merged 1 commit into
pymmcore-plus:mainfrom
gselzer:com-table-visibility

Conversation

@gselzer

@gselzer gselzer commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

On Windows, I've found it a bit tricky to assign COM port properties to devices when using the Hardware Configuration Wizard:

python_C50MiGbEkj

Now, this PR changes the behavior to this:

python_dhEjMvyfPi

Note that Qt.WindowType.MSWindowsFixedSizeDialogHint prevents us from resizing that window. I elected to not mess with that here, in favor of just resizing the widget to always fit the whole table, because we're not talking about too many rows for COM/TCP ports. But it's a weak personal preference that I'd be open to changing.

Also, I didn't add a test because I didn't immediately see a way to get access to a COM port, if someone knows how let me know!

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.36%. Comparing base (dbabfa5) to head (1d8e42a).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/pymmcore_widgets/hcwizard/_dev_setup_dialog.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   88.70%   87.36%   -1.34%     
==========================================
  Files         115      115              
  Lines       13781    14098     +317     
==========================================
+ Hits        12224    12317      +93     
- Misses       1557     1781     +224     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03
tlambert03 merged commit d61a158 into pymmcore-plus:main Jul 19, 2026
15 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants