Skip to content

chore: bump PyQt6 version - #170

Merged
gselzer merged 2 commits into
pymmcore-plus:mainfrom
gselzer:bump-pyqt6-version
Aug 18, 2026
Merged

gselzer merged 2 commits into
pymmcore-plus:mainfrom
gselzer:bump-pyqt6-version

Conversation

@gselzer

@gselzer gselzer commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

This would avoid any errors arising from micro-manager/pymmcore#182 - I haven't run into any of those here yet but this does prevent me from bumping pymmcore-openscan's version, where I am running into those errors in testing.

@tlambert03 is there a reason you know of that we are enforcing PyQt6 v6.9.0 in particular?

@gselzer gselzer changed the title Bump PyQt6 version chore: bump PyQt6 version Aug 18, 2026
@codecov

codecov Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.69%. Comparing base (e6ca514) to head (9617bd2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   82.47%   82.69%   +0.22%     
==========================================
  Files          29       29              
  Lines        1815     1815              
==========================================
+ Hits         1497     1501       +4     
+ Misses        318      314       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03

Copy link
Copy Markdown
Member

I don't remember these things off hand. It's always some balance of compatibilities, backed up by tests. If the pr that set it to 6.9 is not informative, and if bumping again just fixes it and doesn't break anything else, I'm definitely fine with it.

@gselzer
gselzer force-pushed the bump-pyqt6-version branch from 41d1a81 to b7c4cf6 Compare August 18, 2026 20:12
@gselzer
gselzer force-pushed the bump-pyqt6-version branch from b7c4cf6 to 9617bd2 Compare August 18, 2026 20:33
@gselzer

gselzer commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

I don't remember these things off hand.

Of course, just making sure 🙂

It's always some balance of compatibilities, backed up by tests. If the pr that set it to 6.9 is not informative, and if bumping again just fixes it and doesn't break anything else

All of the tests are passing on CI and things work well on my machine, so I'm going to say it is good!

@gselzer
gselzer merged commit 2634ee6 into pymmcore-plus:main Aug 18, 2026
14 checks passed
@gselzer
gselzer deleted the bump-pyqt6-version branch August 18, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants