Stop Native hot reload from scanning logs and vendor - #140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
vendorfiles out of the Native hot-reload fingerprint, while continuing to detect source edits.Why
The immutable v1.0.30 release candidate entered an endless reload cycle because the first-run gate saved
pam devoutput inside the app directory. Scanningvendoron every 100 ms poll also wasted CPU on files managed by Composer.Validation
cargo test --locked --workspacephp packages/native/tests/run.phpphp scripts/test-release-workflows.phpcargo fmt --all -- --checkscripts/composer-package.sh validate-tag v1.0.31