fix(layout): measure intrinsic row and text sizes with resolved child widths - #137
Merged
Merged
Conversation
(cherry picked from commit b79f5b4)
(cherry picked from commit ef981e6)
(cherry picked from commit 451e296)
(cherry picked from commit d6a6a87)
(cherry picked from commit 634ef37)
(cherry picked from commit f83eaa3)
(cherry picked from commit 3f6e17d)
(cherry picked from commit 3e62949)
…tered controls (cherry picked from commit d9d5b30)
(cherry picked from commit 7137867)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since the variable-font measurement work, a
Rowwhose children are flexible controls (flex-grow: 1; min-width: 0) holding an icon and a label — e.g. a quick-action bar ofPressables — is laid out with a collapsed cross size (a 7 dp tall row whose children overflow and get clipped), and a fixed 48×48Pressablebeside a text column in aspace-betweenrow can disappear entirely. Linkinpay's Home renders correctly with the 1.0.13 engine and breaks with 1.0.26/1.0.28.Change
Cherry-picks the ordered engine-only layout fixes from the local
fix/intrinsic-text-cross-widthline (author: davidbalbino), which are self-contained incrates/pam-native-engine/src/layout.rs:Engine suite: 75 tests pass. Verified on an API 36 emulator with the Linkinpay Home: header account button and the quick-action row regain their full frames.
🤖 Generated with Claude Code