Repository navigation
Conversation
…Map name deployment-api.yaml and deployment-manager.yaml hardcoded the literal string "vmpooler-pools" as the second configmap.reloader.stakater.com/reload target instead of templating .Values.poolsConfigMapName. Consumers that override poolsConfigMapName (e.g. dio-helm-charts' dio-vmpooler chart sets it to "dio-vmpooler-pools") never get picked up by Reloader, so pool config changes silently require a manual rollout restart. Confirmed via `helm template --set poolsConfigMapName=dio-vmpooler-pools`: the annotation now renders "vmpooler-baseconfig,dio-vmpooler-pools" instead of "vmpooler-baseconfig,vmpooler-pools". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployment-api.yamlanddeployment-manager.yamlhardcoded the literal stringvmpooler-poolsas the second target ofconfigmap.reloader.stakater.com/reload, instead of templating.Values.poolsConfigMapName.poolsConfigMapName(e.g.dio-helm-charts'sdio-vmpoolerchart sets it todio-vmpooler-pools) never gets picked up by Stakater Reloader, so pool config changes silently require a manualkubectl rollout restart- discovered while shipping a vmpooler template fix (P4DEVOPS-16180) on bothvmpooler-devandvmpooler-prod, where neither environment auto-restarted after the ConfigMap updated.3.10.4.Confirmed via
helm template --set poolsConfigMapName=dio-vmpooler-pools: the annotation now rendersvmpooler-baseconfig,dio-vmpooler-poolsinstead of the stalevmpooler-baseconfig,vmpooler-pools.Test plan
helm lint helm-charts/vmpoolerhelm templatewithpoolsConfigMapNameoverride renders the corrected annotationdio-helm-charts'svmpoolerdependency to3.10.4and confirm a pool config change auto-restartsvmpooler-dev/vmpooler-prodwithout a manual rollout restart🤖 Generated with Claude Code