Repository navigation
Conversation
The local view records a person's row decision silently, so a coordinator reading only the needs-the-person section never learns to run spec apply. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap
When the person approves or declines a row in the local view (port 4891), the decision is recorded on the board but nothing tells the coordinator.
personNeedsdeliberately excludes rows with a recorded decision (src/needs.js, tested by "approved and declined unapplied rows stay out"), and the relay path's "View request N: Apply the person's recorded row decision" shout only fires for relay/paired-view requests. So on a local board the coordinator'spullboard resumesays nothing, the row stays unapplied, and the person sees their approval ignored.Observed on board superagent, 2026-11-04: G9 approved in the local view; three coordinator resumes later it was still pending apply.
Fix
src/resume.js:pendingRowApply,rowDecisionLinesandapplyFirst, besidecommitFirst.src/commands/resume.js: the coordinator card carriespendingApply(id, kind, decision), saysThe coordinator must apply the person's recorded row decision: G9 approved, pending apply: cd <root> && pullboard spec apply, andnextstarts withapply the person's recorded row decisions first: ...; then <next>. Inbox stays outermost.personNeedsunchanged.Test
test/resume-flow.test.js: draft, commit,spec approve G1without apply, thenresumeandresume --jsonname the pending decision and lead with the apply; afterspec applyboth are quiet. Seen failing before the fix (pendingApplyundefined), passing after.node bin/run-tests.js test/resume-flow.test.js test/needs.test.js test/coordinator-resume.test.js: 35/35.🤖 Generated with Claude Code