Repository navigation
fix(relay): keep provider outages distinct from access denials [H8,H16] - #12
Draft
McHersheys wants to merge 3 commits into
Draft
McHersheys wants to merge 3 commits into
McHersheys wants to merge 3 commits into
Conversation
… [skip ci] Draft contribution: focused regressions and offline contract note. Product tests and gate are unrun; no runtime adoption or permission/ACK bypass.
Signed-off-by: McHerpes <mchermes@edu.dreamcatcher.ai>
coreyolson
added
the
bug
1 of 4 tasks
coreyolson
added
the
pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Keep transient GitHub-provider failures distinct from access denials: recognize primary/secondary rate-limit responses and return HTTP 503 without invalidating a still-valid read cache. Permission denials remain denials; no authorization or relay-ACK bypass.
The revision removes the repeated endpoint/status matrix and reuses the existing test files and fixtures. The complete diff is 93 additions, 1 deletion; runtime changes remain seven lines. Related: #11.
Which approved spec rows does this serve?
H8 and H16. The opt-in outbox regression also cites draft H21, not H17 (pairing). This does not implement exclusive offline authority.
How was it proven?
Node v24.21.0, real loopback HTTP, Git and SQLite, isolated temporary state:
npm test -- --test-concurrency=2 test/relay-github.test.js test/relay.test.js test/relay-outbox.test.js: 64 passed; zero failed, skipped or cancelled.node bin/pullboard.js spec check: passes with complete Git history, both at the upstream base and this candidate.The three regressions cover distinct classifier/fallback, HTTP/cache, and outbox/replay boundaries; they are a practical nonredundant selection, not a claim of mathematical minimum. Existing denial, conflict and multiple-machine controls remain intact.
Draft / not accepted: the complete gate and browser suite have not passed in this environment; browser prerequisites are absent. An initial archive-only spec check falsely reported duplicate IDs because its Git history was missing; supplying full history corrected that setup error without changing source. No upstream duplicate-ID bug is claimed. No merge, release or deployment is requested by this draft update.