Python 2 & 3 compatible code - #14
Open
CrimsonGlory wants to merge 10 commits into
Open
Conversation
Just for the sake of the upstream PR we are moving back to tabs.
|
I just tried this and get an error: The relevant line from /proc/mounts is "/dev/root / ext4 rw,noatime 0 0" and /dev/root does not expolicitly exist. I'm on Gentoo with kernel 6.14.5. I'm not really sure which utility or python call should be able to figure out the real device here (/dev/nvme0n1p2 in my case.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have adapted the code so that it is compatible both with python 2.7 and python 3.
The code was tested with python versions 2.7.12, 2.7.17, 3.5.2 and 3.6.9 (just because those were the versions installed on the machines that I have with raid).