Repository navigation
fix: link alert players and outfits to their profiles - #835
Merged
Merged
Conversation
Player and outfit names in an alert's players and outfits tables are now the same profile buttons the statistics leaderboards use, pointing at the alert's own server. "No outfit" placeholders stay as plain text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The outfitwar prop defaults to an object without a world, which failed the Nuxt type check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual steps
No manual steps or intervention required.
What this does
On an alert's page, every player name in the players table and every outfit name in the players and outfits tables is now a profile button, the same style the statistics leaderboards use. Links point at the alert's own server, because an outfit record's embedded server can be stale. The "-- NO OUTFIT --" placeholders (outfit ids 0 to 4) stay as plain text.
Validation done
eslintclean. Checked on alert 10-46007 against the live API: 20 player and 34 outfit buttons on the first page of each table, all pointing at Wainwright, with the four no-outfit rows left as text.🤖 Generated with Claude Code