Repository navigation
chore: install jest and run the tests in CI - #1026
Merged
Merged
Conversation
Mirrors the api's setup (ps2alerts/api#736): jest with ts-jest, specs alongside the source, and a Tests workflow on every PR. The first spec pins the API queue declarations, including the options that must match the api's own declaration of api-queue-production. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Maelstromeous
marked this pull request as ready for review
September 29, 2026 11:23
Maelstromeous
added a commit
that referenced
this pull request
Sep 29, 2026
* perf: keep api-queue-production in memory, off the disk api-queue-production was durable, lazy and fed persistent messages, so RabbitMQ 3.10 wrote every message to disk even though the api drains it to about zero. It is now non-durable, non-lazy and published transient. The delay queues stay durable, lazy and persistent. Must match the api's declaration of the same queue (ps2alerts/api), and the existing queue has to be deleted and redeclared once before deploy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore: install jest and run the tests in CI (#1026) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No manual steps or intervention required.
Stacked on #1025. Merge that first, and GitHub retargets this one to
main.What this does
@types/jest, atestscript and a Tests workflow, mirroring chore: install jest and run the tests in CI api#736. Specs sit next to the source and are already excluded from the build bytsconfig.build.json.ApiMQPublisherdeclares with the 3 h TTL anddurable: falsethat the api's own declaration uses (perf: declare api-queue-production memory-only, matching the aggregator api#737).Validation done
yarn test: 3 of 3 pass.yarn run lint:checkandyarn run buildare clean, and no spec reachesdist/.ApiMQPublisherwas switched back to a durable declaration.🤖 Generated with Claude Code