Repository navigation
build: use pnpm and workspace:* for @prosopo/config - #10
Merged
Merged
Conversation
Scripts call pnpm instead of npm/npx, the npm engine is dropped, and @prosopo/config resolves to the captcha workspace copy. ua-parser-js is declared for the tests, which npm only found through hoisting. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Sep 29, 2026
HughParry
marked this pull request as ready for review
September 29, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Part of moving our repos from npm to pnpm. This package lives inside the captcha workspace, so it now:
pnpminstead ofnpm/npx,@prosopo/configasworkspace:*(the local copy) instead of an old registry version,ua-parser-js, which its tests import but only ever found through npm's hoisting.Effect
None at runtime. It only builds and tests correctly inside the pnpm workspace.
Tests
Built and tested inside the migrated captcha workspace. The captcha PR is linked below.
Merge order
Merge first, then bump the pointer in the captcha PR.
Links: #10 · prosopo/captcha#3447 · prosopo/Protect#1120 · prosopo/docs#106 · prosopo/captcha-private#5035