Repository navigation
Fix the release build: build:tsc waits for the package's own types - #3609
Merged
Merged
Conversation
The release build runs turbo build:tsc, which since #3605 only waited for dependencies' dist/types. @prosopo/types imports itself by name, so the v3.9.3 publish failed resolving it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
build:tscinturbo.jsonnow also depends on the package's ownbuild:types, not just its dependencies'.Why
Since #3605, packages resolve each other's types from
dist/types, butbuild:tscwrites todist/tsc.@prosopo/typesimports itself by name in two files, as do someproviderandapi-routetests. In a fresh checkout those imports can't resolve until the package's owndist/typesexists. That's why the v3.9.3 release failed at "Build packages" (run):PR CI didn't catch it because
typecheckalready depends on the package's ownbuild:types.Testing
I reproduced the release's "Build packages" step in a fresh checkout of
main(with submodules), production mode, nothing cached:build:all:tscfails with the error abovebuild:all:tsc110/110,build:all112/112,build:all:cjs56/56Once this is merged, a new release (v3.9.4) is needed to ship #3602.
🤖 Generated with Claude Code