Repository navigation
Check the image captcha type before the requested dataset - #3607
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
When someone asks the provider for an image challenge, it now checks "does this site key serve image captchas?" before "does the dataset you named exist?". #3409 (in 3.9.1) put the dataset check first.
Effect
INCORRECT_CAPTCHA_TYPEagain, whateverdatasetIdit sends. Since 3.9.1 it got "Unknown dataset" (INVALID_REQUEST:PROV-94).Tests
imageChallengeClientDatasetId.unit.test.ts: a wrong-type key that sends an unknowndatasetIdgetsINCORRECT_CAPTCHA_TYPE, and the dataset is never looked up. It fails without this change.imgCaptchaManager, because the handler now gets to the type check before the dataset check.🤖 Generated with Claude Code