Repository navigation
Provider: reject requests where the header and body site keys differ - #3391
Merged
Merged
Conversation
domainMiddleware checks the origin allowlist of the prosopo-site-key header, but the handlers use the dapp in the body. Reject requests where the two differ, so a site's allowlist cannot be sidestepped by sending another key in the header (including a reserved test key).
Keep main's domainMiddleware test harness and add the body/header site-key cases to it; invalidSiteKeyError now takes only the site key.
HughParry
marked this pull request as ready for review
October 26, 2026 12:06
HughParry
enabled auto-merge (squash)
October 26, 2026 12:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SITE_KEY_INVALID) if the body'sdappisn't the same as theprosopo-site-keyheader.Why
Effect
Tests
/procand the Linux native addon).