Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/ci-pin-third-party-actions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
---

Third-party GitHub Actions are now pinned to full commit SHAs instead of mutable tags (the tag stays as a trailing comment). A moved or compromised tag would otherwise run new code with whatever the step holds — here the release GitHub App private key (workflow-application-token-action), Docker Hub and AWS credentials, and write tokens. First-party `actions/*` and `github/*` are left on tags.
2 changes: 1 addition & 1 deletion .github/workflows/android-webview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
java-version: "17"

- name: Set up Android SDK
uses: android-actions/setup-android@v4
uses: android-actions/setup-android@be39fa834029ff78f1a44aa3bb0819b8fc2bd8fd # v4
with:
# Drop the action's default `tools platform-tools`. `tools` is an
# obsolete SDK package that Google has removed from the repository,
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create_release_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
steps:
- name: Get token for gh app
id: app_token
uses: peter-murray/workflow-application-token-action@v5
uses: peter-murray/workflow-application-token-action@dad2b81e50ce3edeb5f3b7ffbd79f731368bd668 # v5
with:
application_id: ${{ vars.PROSOPONATOR_APP_ID }}
application_private_key: ${{ secrets.PROSOPONATOR_APP_PRIVATE_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cypress-baselines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ jobs:
EOF

- name: Open PR with regenerated baselines
uses: peter-evans/create-pull-request@v8
uses: peter-evans/create-pull-request@5f6978faf089d4d20b00c7766989d076bb2fc7f1 # v8
with:
token: ${{ secrets.PROSOPONATOR_PAT }}
add-paths: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/provider_image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,14 @@ jobs:
- run: NODE_ENV="production" npx turbo run @prosopo/cli#bundle

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v4
uses: docker/setup-buildx-action@f87e5991a6d7451dcb8d9637bfbc97413f497069 # v4

# We cannot create the images in a single step because the output of buildx is not compatible with
# `docker load`. https://stackoverflow.com/a/72952846/1178971

# create the provider image for AMD64
- name: Build the Provider Container
uses: docker/build-push-action@v7
uses: docker/build-push-action@c3c9e263c25d99ce0380d002d59b67737d91b0dc # v7
with:
context: ${{github.workspace}}
file: ${{github.workspace}}/packages/cli/Dockerfile
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
steps:
- name: Get token for gh app
id: app_token
uses: peter-murray/workflow-application-token-action@v5
uses: peter-murray/workflow-application-token-action@dad2b81e50ce3edeb5f3b7ffbd79f731368bd668 # v5
with:
application_id: ${{ vars.PROSOPONATOR_APP_ID }}
application_private_key: ${{ secrets.PROSOPONATOR_APP_PRIVATE_KEY }}
Expand All @@ -63,7 +63,7 @@ jobs:
cache: 'npm'

- name: Log in to Docker Hub
uses: docker/login-action@v4
uses: docker/login-action@dbcb813823bdd20940b903addbd779551569679f # v4
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tag_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
steps:
- name: Get token for gh app
id: app_token
uses: peter-murray/workflow-application-token-action@v5
uses: peter-murray/workflow-application-token-action@dad2b81e50ce3edeb5f3b7ffbd79f731368bd668 # v5
with:
application_id: ${{ vars.PROSOPONATOR_APP_ID }}
application_private_key: ${{ secrets.PROSOPONATOR_APP_PRIVATE_KEY }}
Expand Down
Loading