Repository navigation
Frictionless: do nothing after the widget is destroyed - #3362
Merged
Merged
Conversation
destroy() only guarded the solver mounts. A /frictionless response that landed after destroy could still mount the authenticated badge (firing onHuman), report onError, keep retrying through providerRetry, or add a restart timer to an already-run Teardown so it could never be cleared and later fired onReset and restart. start(), the post-detection path, renderForCaptchaType, the retry finaliser and restartComponentTimeout now all bail once destroyed.
HughParry
force-pushed
the
fix/frictionless-stop-after-destroy
branch
from
October 26, 2026 13:39
2e3f60d to
fde2fdc
Compare
HughParry
marked this pull request as ready for review
October 26, 2026 13:41
HughParry
enabled auto-merge (squash)
October 26, 2026 13:45
…ictionless-stop-after-destroy # Conflicts: # packages/procaptcha-frictionless/src/tests/procaptchaFrictionless.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
/frictionlessresponse arriving after destroy could still fireonHumanfor a dead widget, fireonError, retry other providers up to 5 times, or leave a timer that later firedonReset.Effect
Tests