alertmanager: add several secret-file fields#8537
Open
cjyar wants to merge 5 commits into
Open
Conversation
Discord and MS Teams have webhook_url_file fields in alertmanager, but those fields aren't supported by the operator. I checked all of the secret-file style fields in the alertmanager docs, and these were the only two missing that I found. I also reordered fields for weChat.
| VSendResolved *bool `yaml:"send_resolved,omitempty"` | ||
| HTTPConfig *httpClientConfig `yaml:"http_config,omitempty"` | ||
| WebhookURL string `yaml:"webhook_url,omitempty"` | ||
| WebhookURLFile string `yaml:"webhook_url_file,omitempty"` |
Member
There was a problem hiding this comment.
Need set/get function and add it crd
Author
There was a problem hiding this comment.
@dongjiang1989 I don't see set/get functions for other similar fields (like victorOpsConfig.APIKeyFile). Can you please show me where those are?
Also, I don't believe this change requires any modification to the AlertmanagerConfig CRD. Again, I'm comparing to existing fields that store secret filenames, like victorOpsConfig.APIKeyFile.
However, I did add some unit tests and fix validation for these new fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord and MS Teams have webhook_url_file fields in alertmanager, but those fields aren't supported by the operator. I checked all of the secret-file style fields in the alertmanager docs, and these were the only two missing that I found. I also reordered fields for weChat.
Description
Alertmanager has
webhook_url_filefields for Discord and MS Teams, but those fields aren't supported by the operator. This PR adds that support.Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
I haven't tested this; sorry. I don't have a suitable system for running tests. I'm typing this on a Windows box.
Changelog entry