Repository navigation
fix: keep the flash duck off during the Up+Down clock - #627
Merged
Merged
Conversation
The clock wake fades the light in, then draws the clock and, on release, the next sleep screen. Each flashing refresh started a duck that dipped the light and brought it back, so the short peek pumped the light twice before the sleep fade-out. The clock wake now never ducks. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
prokrypt
enabled auto-merge (squash)
November 11, 2026 20:29
auto-merge was automatically disabled
November 11, 2026 22:03
Pull request was closed
prokrypt
enabled auto-merge (squash)
November 11, 2026 22:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Clankmaster · project thread
The Up+Down clock wake fades the light in (
Frontlight.begin), draws the clock (Half when no retained panel frame, else Fast), and on release draws the next sleep screen beforefrontlightFadeOutForSleep(). With Flash Duck on, each flashing refresh started a duck whose steps retarget the running fade and then dip and restore the light, so a few-second peek pumped the light up to twice before the fade-out.The duck now never starts on a clock wake (
wallpaperChordWake), in both its start check andflashDuckPending(), so the 10 ms duck timer doesn't arm either. The clock boot always ends in deep sleep, so nothing else is affected.Not checked on the device: no log of a clock wake with the light on exists yet.
🤖 Generated with Claude Code