Repository navigation
fix: log the light timeout in the battery log when the fade is dark - #624
Merged
Merged
Conversation
The light timeout wrote its "light off" battery-log row when the fade started, so every timeout under-counted lit time by the fade length. The row now waits until the fade ramp has ended; input that restores the light mid-fade cancels it, as the light never went dark. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QrEdpxLkuVrifx7ahhZV13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Clankmaster · project thread
Review finding: the light timeout (
src/main.cpp, smooth fades) wrote its battery-log "light off" row when the fade started, so each timeout under-counted lit time by the fade (KnobslightFadeMs, default 1000 ms).Fix: the fade start records when the ramp ends; the loop writes the row once that time passes. Input that restores the light before then cancels it, since the light never went dark (the restore's own
lightChanged()is then a no-op, so no off/on pair). Fade, light and input behavior are unchanged; only when the log row is written.Hardware check: X4 Pro, Light Timeout short, light on, idle until it fades.
debug/logsbattery log "light" row lands about the fade length after the "Light timeout: fading" debug line. Tap during a fade: no light row.Generated by Claude Code