Merge branch 'develop' into dependabot/npm_and_yarn/multi-339deb07ce

Author: raclim

client/modules/About/pages/About.tsx

@@ -167,7 +167,7 @@ export const About = () => {
             <a
               href="https://github.com/processing/p5.js-web-editor/releases"
               target="_blank"
-              rel="noreferrer"
+              rel="noopener noreferrer"
             >
               {t('About.WebEditor')}: <span>v{packageData?.version}</span>
             </a>
@@ -176,7 +176,7 @@ export const About = () => {
             <a
               href="https://github.com/processing/p5.js/releases"
               target="_blank"
-              rel="noreferrer"
+              rel="noopener noreferrer"
             >
               p5.js: <span>v{p5version}</span>
             </a>

client/modules/IDE/actions/assets.js

@@ -30,7 +30,10 @@ export function getAssets() {
 export function deleteAssetRequest(assetKey) {
   return async (dispatch) => {
     try {
-      await apiClient.delete(`/S3/${assetKey}`);
+      const path = assetKey.split('/').pop();
+      await apiClient.delete(
+        `/S3/delete?objectKey=${encodeURIComponent(path)}`
+      );
       dispatch(deleteAsset(assetKey));
     } catch (error) {
       dispatch({

client/modules/IDE/components/AssetListRow.jsx

@@ -22,7 +22,7 @@ const AssetMenu = ({ item: asset }) => {
   return (
     <TableDropdown aria-label={t('AssetList.ToggleOpenCloseARIA')}>
       <MenuItem onClick={handleAssetDelete}>{t('AssetList.Delete')}</MenuItem>
-      <MenuItem href={asset.url} target="_blank">
+      <MenuItem href={asset.url} target="_blank" rel="noopener noreferrer">
         {t('AssetList.OpenNewTab')}
       </MenuItem>
     </TableDropdown>

client/modules/IDE/components/Preferences/index.jsx

@@ -118,7 +118,7 @@ export default function Preferences() {
   const markdownComponents = useMemo(() => {
     // eslint-disable-next-line react/no-unstable-nested-components
     const ExternalLink = ({ children, ...props }) => (
-      <a {...props} target="_blank">
+      <a {...props} target="_blank" rel="noopener noreferrer">
         {children}
       </a>
     );
@@ -618,7 +618,7 @@ export default function Preferences() {
                   <legend className="preference__warning">
                     <a
                       target="_blank"
-                      rel="noreferrer"
+                      rel="noopener noreferrer"
                       href={`https://${
                         versionInfo.isVersion2 ? 'beta.' : ''
                       }p5js.org/reference/p5.sound`}

client/modules/IDE/components/QuickAddList/QuickAddList.jsx

@@ -37,6 +37,7 @@ const Item = ({ isAdded, onSelect, name, url }) => {
         className="quick-add__item-view"
         to={url}
         target="_blank"
+        rel="noopener noreferrer"
         onClick={(e) => e.stopPropagation()}
       >
         {t('QuickAddList.View')}

client/modules/IDE/components/show-hint.js

@@ -323,13 +323,15 @@ import CodeMirror from 'codemirror';
       return `<div class="hint-container">${hintHTML}</div>`;
     }
   }
-
+  
+  
   function getInlineHintSuggestion(cm, focus, token) {
     let tokenLength = token.string.length;
     if (token.string === '.') {
       tokenLength -= 1;
     }
     const name = focus.item?.text;
+
     const suggestionItem = focus.item;
     // builds the remainder of the suggestion excluding what user already typed
     const baseCompletion = `<span class="inline-hinter-suggestion">${suggestionItem.text.slice(

server/controllers/aws.controller.js

@@ -65,8 +65,9 @@ export async function deleteObjectsFromS3(keyList) {
 }
 
 export async function deleteObjectFromS3(req, res) {
-  const { objectKey, userId } = req.params;
-  const fullObjectKey = userId ? `${userId}/${objectKey}` : objectKey;
+  const userId = req.user.id;
+  const { objectKey } = req.query;
+  const fullObjectKey = `${userId}/${objectKey}`;
 
   try {
     await deleteObjectsFromS3([fullObjectKey]);

server/routes/aws.routes.ts

@@ -10,11 +10,7 @@ router.post(
   isAuthenticated,
   AWSController.copyObjectInS3RequestHandler
 );
-router.delete(
-  '/S3/:userId?/:objectKey',
-  isAuthenticated,
-  AWSController.deleteObjectFromS3
-);
+router.delete('/S3/delete', isAuthenticated, AWSController.deleteObjectFromS3);
 router.get('/S3/objects', AWSController.listObjectsInS3ForUserRequestHandler);
 
 // eslint-disable-next-line import/no-default-export

translations/contributor_docs/ko/README.md

@@ -34,5 +34,5 @@ p5.js 웹 에디터에서 버그를 발견하셨다면, [“이슈” 탭](https
 본 프로젝트는 [프로세싱 재단](https://processingfoundation.org/), [뉴욕대 ITP](https://tisch.nyu.edu/itp), [뉴욕시 교육부의 CS4All](http://cs4all.nyc/)에서 후원해주셨습니다.
 
 호스팅과 기술적 지원은 다음 단체들에서 해주셨습니다:<br />
-<a href="https://www.browserstack.com/" target="_blank"><img width="100" src="https://user-images.githubusercontent.com/6063380/46976166-ab280a80-d096-11e8-983b-18dd38c8cc9b.png" /></a> <a href="https://mlab.com" target="_blank"><img width="100" src="https://user-images.githubusercontent.com/6063380/46976572-dbbc7400-d097-11e8-89fe-c7bb08ed0775.png" /></a>
+<a href="https://www.browserstack.com/" target="_blank" rel="noopener noreferrer"><img width="100" src="https://user-images.githubusercontent.com/6063380/46976166-ab280a80-d096-11e8-983b-18dd38c8cc9b.png" /></a> <a href="https://mlab.com" target="_blank" rel="noopener noreferrer"><img width="100" src="https://user-images.githubusercontent.com/6063380/46976572-dbbc7400-d097-11e8-89fe-c7bb08ed0775.png" /></a>