Skip to content

Commit 3b6225c

Browse files
authored
Merge branch 'develop' into dependabot/npm_and_yarn/multi-339deb07ce
2 parents 257d3c0 + 155b4e8 commit 3b6225c

2 files changed

Lines changed: 17 additions & 1 deletion

File tree

contributor_docs/preparing_a_pull_request.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,17 @@ Then ask git about the latest changes.
5151
git status
5252

5353
## Pull Request Templates
54-
Once you've opened your pull request, please ensure that you follow the guidelines.
54+
55+
Once you've opened your pull request, please ensure that you follow the guidelines **and verify the following before submitting for review:**
56+
57+
- ✅ Your code has no linting errors (`npm run lint`)
58+
- ✅ All tests pass successfully (`npm run test`)
59+
- ✅ Your branch name is unique and based off the latest `develop` branch
60+
- ✅ The pull request title and description clearly describe the change
61+
- ✅ Your pull request links to the related issue number (e.g., `Fixes #1234`)
62+
- ✅ Screenshots or videos are included if the change affects the user interface
63+
64+
Following these steps helps maintain code quality and makes it easier for maintainers to review and merge your contribution.
5565

5666
## CONFLICTS
5767
You may have some conflicts! It's okay. Feel free to ask for help. If merging with the latest upstream `develop` branch causes conflicts, you can always make a pull request with the upstream repository, which makes the merge conflicts public.

contributor_docs/styling.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,11 @@
33
Currently in progress.
44

55
---
6+
Additional Resources:
67
- [Zeplin File with Official Colors](google.com/url?q=https://github.com/processing/p5.js-web-editor/wiki/Color-Combinations-for-Accessibility&sa=D&source=docs&ust=1769528946688435&usg=AOvVaw2626esAvAi1JMEjarRcDcT)
78
- [Accessible Links Color Combinations](https://scene.zeplin.io/project/55f746c54a02e1e50e0632c3)
9+
10+
Tips when making styling contributions:
11+
- Define color specifications and other design tokens as CSS custom properties (e.g. `--var(primary-color)`) instead of hard coded values like HEX, RGB ..etc.
12+
- Ensure your changes only affect what you intend. For example, review what uses a variable before modifying it to avoid unintended changes.
13+
- Before creating a new CSS, check for utility classes and variables that provide styling you need.

0 commit comments

Comments
 (0)