Repository navigation
docs(design): a node's address is its logical ID on the platform (ADR-0051) #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Minor · consistency — Bucket
logicalIdwriter attributed to upstream alchemy#1849, contradicting the cited ADR-0048The status bullet says the App, Database and Bucket rows get their
logicalIdprop from "the upstream Alchemy resource that creates the row", citing ADR-0048 (ADR-0051 states the same at line 49). But ADR-0048 still says Composer "defines its own resources only where the upstream provider has no support yet (buckets, whose routes upstream deferred)". Current code uses upstreamPrisma.Bucket/Prisma.BucketProvider()(providers.ts, descriptors/bucket.ts), so this ADR matches the code — but a reader following the citation lands in a document that states the opposite, and unlike ADR-0006/ADR-0024, ADR-0048 got no amendment note for a decision this ADR relies on.Recommended fix
Add an amendment note to ADR-0048 (and its README index entry) recording that the bucket family now composes upstream's
Prisma.Bucketprovider, mirroring the ADR-0006/ADR-0024 amendment notes this ADR added — or soften the citation here and in ADR-0051.