Repository navigation
One Address component for every address on screen - #106
Merged
Merged
Conversation
Addresses were drawn four ways: CopyText with grouped(), raw mono T, shortAddress() in the body face, and a hand-styled mono span in the transaction title. Half the short forms were in Figtree, not Plex Mono. Address has two forms. Short (first 10…last 6, mono 15) stands in for a name; with `detail` it is mono 13 in Muted under a name. Full (groups of 4, mono 13) is for checking and copying; `copy` makes it tap-to-copy. AddressInline puts a short address inside a sentence. Screen readers hear a short address as "address ending" plus its last 6 characters (spokenAddress), not letters and an ellipsis. No part of an address is dimmed or highlighted, because address poisoning copies the ends. The rule is now in design guide §5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A full address is ~36 groups over 5-7 lines. Alternating Text and Muted helps someone keep their place while comparing it group by group. Every group weighs the same, so it doesn't favour the ends the way a highlight would. Spaces stay, so colour is never the only separator. Muted passes AA on every ground (6.6-8.3:1). The same in the native confirm and contact sheets (AddressText in Kit.swift, Kit.address in Kit.kt). The short form stays one colour. Also drops imports and formatting left over from the first commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Alternating per group checkerboarded once text wrapped wherever it ran out of room, and centred lines shifted sideways. Now a full address is laid out in lines of as many groups as fit (8, 6, 4 or 2: always even), sharing one left edge, so the groups stand in columns: odd ones in Text, even ones in Muted. Larger text gets fewer columns, never a wrapped line. RN measures its width (groupsPerRow, addressRows in format.ts), iOS picks the widest layout with ViewThatFits, and Android re-lines its TextView once laid out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…irst Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… address's end On Receive the centred copy block shrank to its content, so the columns measured themselves and spiralled down to two (14 lines, buttons off screen). CopyText now stretches when centred. An Activity row whose title holds an address may take two lines, so the last characters, the ones people compare, aren't cut. Sent shows the address inline in mono instead of a pre-shortened name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…'t move it On Receive and the exchange address, "Copied" appeared above the address and pushed it down about 20 pt. The line now stays, empty until copied. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Addresses were drawn four different ways:
CopyText+grouped(), a raw monoT,shortAddress()in the body face, and a hand-styled mono span in the transaction title. About half the short forms were in Figtree rather than Plex Mono, so the same address looked different from screen to screen. That cuts against the design guide's "show the address small, in monospace" (§3.1, §5).What
Addressinmobile/src/components/address.tsx, exported with the other shared pieces:<Address value />(short)utest1abcd…456789, mono 15, one line<Address value detail />.zcashname to show instead (Pay's list, Contacts)<Address value form="full" /><Address value form="full" copy label? /><AddressInline value />.zcashdrift choice, Contacts' "Add … as a contact" / "Pay …"UX decisions
spokenAddressinwallet-native/src/format.ts): the same 6 characters the short form ends with, so they can be compared by ear. This applies to Activity rows' spoken sentence too. The full form is still read group by group.PayPerson.detail(a string that could be a name or an address) becamezcashName, so the row can draw an address in mono and a.zcashname in the text face.AddressText(Kit.swift) andKit.address(Kit.kt): the same columns (iOS picks the widest layout withViewThatFits; Android re-lines its TextView once it knows its width), mono and selectable.New theme token
size.monoName(15). Design guide §5 documents the component and its rules.Checks
compileDebugKotlintsc, biome, vitest (mobile 133, wallet-native 162; new tests forspokenAddressand Activity's bare-address title and spoken text)Fixed along the way: on Receive the centred copy block shrank to its content, so the columns measured themselves down to two per line (CopyText now stretches); Activity rows cut an address's last characters; Sent drew the address in sans.
🤖 Generated with Claude Code