Repository navigation
Opt-in payment alerts on mainnet and for view-only wallets (#61) - #104
Merged
Merged
Conversation
Decided 16 Nov: mainnet wallets, view-only ones included, may lend their Orchard viewing key to Lantern Zero for payment alerts, only after a yes on the consent sheet. The sheet already names what a breach or court order could see, and adds a line for view-only wallets (#102). Engine: alerts_allowed is gone, so connect/set_scanning/wake no longer refuse on mainnet or for view-only wallets, and wakes lend the IVK whenever scanning is on. The host-only host-mainnet-alerts feature from #100 is no longer needed and is removed; examples/lantern --mainnet connect --scan now lends directly. App: alertsAvailable is removed from the status on both platforms; Notifications always asks for consent before lending, the mainnet-only "wake-ups only" copy goes, and Me's row is "Payment alerts" on both networks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61's "If yes" step. Decided 16 Nov: A, opt-in only. Mainnet wallets, view-only ones included, can lend their Orchard viewing key to Lantern Zero for payment alerts, but only after a yes on the consent sheet. The sheet already says what a breach or a court order could see while the key is lent. #102 added a line for view-only wallets, which shows from now on.
Engine
alerts_allowedis removed.lantern_connect,lantern_set_scanningandlantern_wakeno longer refuse on mainnet or for view-only wallets.host-mainnet-alertsfeature from Host tool: lend a throwaway mainnet key for Lantern Zero's key check (#61) #100 isn't needed anymore and is removed, including its CI andcheck.shlines.examples/lantern --mainnet connect --scannow lends directly.uivk1…key to lend.App
alertsAvailableis removed from the Lantern status (Swift, Kotlin, TS).Checks:
scripts/check.shpasses (JS checks, clippy, 96 engine tests). Swift and Kotlin only lose lines; they haven't been compiled or run on a phone.Before a store build ships this
notes/legal/scanning-risk-assessment.md). A throwaway mainnet wallet's key is lent to production now for it.🤖 Generated with Claude Code