Move and fix CODEOWNERS#73
Conversation
eFFeeMMe
requested review from
claudio-dalicandro and
nicflower
and removed request for
a team
|
are we sure this is on us? @neslinesli93 @korsmakolnikov 🤔 |
Good question... When fixing the original configuration which had dead teams in it etc. I ended up giving ownership to everybody in Italy to play it safe, but you can remove yourselves if you're not really involved with this. |
| @@ -0,0 +1,5 @@ | |||
| * @primait/claims-operations @primait/claims-settlement @primait/claims-gateway | |||
There was a problem hiding this comment.
should we add sres also here?
There was a problem hiding this comment.
I don't think they care about the Elixir stuff, but you did remind me to add them to /.github! Lemme know if this addresses your comment
|
We use CSV schema also in the CGP. I would probably ad UK and Spain as well |
eFFeeMMe
changed the title
|
I'm optimistically merging even though there's an extant comment from FraZ, I'll open another PR if he requests further changes! Also I'm asking company-iam to remove the dead teams from Personio so that I can avoid mentioning dead teams in CODEOWNERS again 😂 |
|
Turns out that company-iam is not in charge of teams at the Personio level (which float downstream to GitHub and Okta). I've asked the People team. |
4 participants
claims-resolution is no more, claims-settlement is the one I was thinking of.
Also I moved the CODEOWNERS file to the root folder while I was at it.