Skip to content

fix: bound the connect timeout so it does not vary by platform #7106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Atishyy27 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: bound the connect timeout so it does not vary by platform #7106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03b92bd
fix: bound the connect timeout so it does not vary by platform
Atishyy27 Sep 27, 2026
182233a
Merge remote-tracking branch 'origin/main' into fix-connect-timeout
Atishyy27 Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion crates/pixi_utils/src/reqwest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ pub fn oci_middleware(
static DEFAULT_REQWEST_USER_AGENT: LazyLock<String> =
LazyLock::new(|| format!("pixi/{}", consts::PIXI_VERSION));
static DEFAULT_REQWEST_TIMEOUT_SEC: Duration = Duration::from_secs(5 * 60);
/// Bounds only establishing the TCP connection, not the transfer, so it can be
/// far shorter than the read timeout. Without it the OS default applies and
/// differs per platform: roughly two minutes on Linux and five on macOS.
static DEFAULT_REQWEST_CONNECT_TIMEOUT_SEC: Duration = Duration::from_secs(30);
static DEFAULT_REQWEST_IDLE_PER_HOST: usize = 20;

/// The default `TlsRootCerts` mode for the active TLS backend.
Expand Down Expand Up @@ -216,7 +220,8 @@ pub fn reqwest_client_builder(
let mut builder = Client::builder()
.pool_max_idle_per_host(DEFAULT_REQWEST_IDLE_PER_HOST)
.user_agent(DEFAULT_REQWEST_USER_AGENT.as_str())
.read_timeout(DEFAULT_REQWEST_TIMEOUT_SEC);
.read_timeout(DEFAULT_REQWEST_TIMEOUT_SEC)
.connect_timeout(DEFAULT_REQWEST_CONNECT_TIMEOUT_SEC);

#[cfg_attr(
not(any(feature = "native-tls", feature = "rustls")),
Expand Down Expand Up @@ -454,6 +459,14 @@ mod tests {

use super::*;

#[test]
fn connect_timeout_is_shorter_than_the_read_timeout() {
// A connect timeout at or above the read timeout would never fire first,
// leaving the platform default in charge and the bug in place.
assert!(!DEFAULT_REQWEST_CONNECT_TIMEOUT_SEC.is_zero());
assert!(DEFAULT_REQWEST_CONNECT_TIMEOUT_SEC < DEFAULT_REQWEST_TIMEOUT_SEC);
}

#[test]
fn test_uv_middlewares_includes_auth_with_mirrors() {
// Test that authentication middleware is included when mirrors are configured
Expand Down
Loading