Skip to content

perf: diff single-child render results without a wrapper array #5241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoviDeCroock wants to merge 1 commit into from
+4 −4
Closed

perf: diff single-child render results without a wrapper array #5241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/diff/children.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export function diffChildren(
/** @type {VNode[]} */
let oldChildren = oldParentVNode._children || EMPTY_ARR;

let newChildrenLength = renderResult.length;
let newChildrenLength = isArray(renderResult) ? renderResult.length : 1;

oldDom = constructNewChildrenArray(
newParentVNode,
Expand Down Expand Up @@ -184,7 +184,7 @@ function constructNewChildrenArray(
for (i = 0; i < newChildrenLength; i++) {
// @ts-expect-error We are reusing the childVNode variable to hold both the
// pre and post normalized childVNode
childVNode = renderResult[i];
childVNode = isArray(renderResult) ? renderResult[i] : renderResult;

if (
childVNode == NULL ||
Expand Down
4 changes: 2 additions & 2 deletions src/diff/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ export function diff(

oldDom = diffChildren(
parentDom,
isArray(renderResult) ? renderResult : [renderResult],
renderResult,
newVNode,
oldVNode,
globalContext,
Expand Down Expand Up @@ -677,7 +677,7 @@ function diffElementNodes(

diffChildren(
parentDom,
isArray(newChildren) ? newChildren : [newChildren],
newChildren,
newVNode,
oldVNode,
globalContext,
Expand Down
Loading