Repository navigation
Fix SHAKE on big-endian platforms and add aarch64_be CI - #55
Open
mkannwischer wants to merge 5 commits into
Open
mkannwischer wants to merge 5 commits into
mkannwischer wants to merge 5 commits into
Conversation
mkannwischer
changed the title
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Port SLH_SYS_{LITTLE,BIG}_ENDIAN from mlkem-native's sys.h.
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Port keccakf1600_{xor,extract}_bytes from mlkem-native and use them
for all byte access to the Keccak state.
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Port the aarch64_be toolchain from mlkem-native and run the ACVP tests under qemu-aarch64_be. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
mkannwischer
force-pushed
the
fix-shake-big-endian
branch
from
October 13, 2026 16:46
64ba392 to
b08936f
Compare
The nix gcc builds fail to run on current macOS runners (duplicate LC_RPATH). Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Contributor
Author
|
@dstebila, could I ask you for a review for this bug fix, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SHAKE gave wrong results on big-endian targets: the Keccak state was accessed bytewise, but keccak_f1600() works on native-endian lanes. All SHAKE keyGen/sigGen ACVP tests failed on aarch64_be.
Overlaps with #52 in slh_sys.h.