Skip to content

abicheck: Use the native build's CPU feature flags #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanno-becker wants to merge 3 commits into from
+555 −665
Open

abicheck: Use the native build's CPU feature flags #1945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a050f3
Guard assembly with its required CPU features
hanno-becker Oct 20, 2026
300af76
abicheck: Use the platform's CPU feature flags
hanno-becker Oct 11, 2026
9ff7f2e
CI: Enable ABI checks in the Zig 0.17 jobs
hanno-becker Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,9 +292,6 @@ jobs:
# (https://github.com/ziglang/zig/issues/23576). We therefore
# only test the C backend and exclude the native examples.
# - 0.17 fixes this, so we test the native backends as well.
# - The ABI check is not supported with zig: on AArch64 it passes
# -march=armv8-a+simd and -march=armv8.4-a+sha3, which zig rejects
# since it parses -march as a CPU name.
- family: zig
version: "0.10"
shell: zig0_10
Expand Down Expand Up @@ -322,7 +319,6 @@ jobs:
darwin: True
opt: all
examples: True
extra_args: "--no-abicheck"
runs-on: ${{ matrix.target.runner }}
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/legacy-compilers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,6 @@ jobs:
# (https://github.com/ziglang/zig/issues/23576). We therefore
# only test the C backend and exclude the native examples.
# - 0.17 fixes this, so we test the native backends as well.
# - The ABI check is not supported with zig: on AArch64 it passes
# -march=armv8-a+simd and -march=armv8.4-a+sha3, which zig rejects
# since it parses -march as a CPU name.
- family: zig
version: "0.10"
shell: zig0_10
Expand Down Expand Up @@ -244,7 +241,6 @@ jobs:
shell: zig0_17
opt: all
examples: True
extra_args: "--no-abicheck"
runs-on: ${{ matrix.target.runner }}
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down Expand Up @@ -435,7 +431,6 @@ jobs:
shell: zig0_17
opt: all
examples: True
extra_args: "--no-abicheck"
runs-on: macos-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
8 changes: 5 additions & 3 deletions dev/aarch64_clean/src/mlkem_intt_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && \
(!defined(MLK_CONFIG_NO_ENCAPS_API) || \
!defined(MLK_CONFIG_NO_DECAPS_API))
Expand Down Expand Up @@ -402,5 +403,6 @@ mlk_intt_layer123_start:
.unreq ninv_tw

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
(!MLK_CONFIG_NO_ENCAPS_API || !MLK_CONFIG_NO_DECAPS_API) */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && (!MLK_CONFIG_NO_ENCAPS_API || \
!MLK_CONFIG_NO_DECAPS_API) */
6 changes: 4 additions & 2 deletions dev/aarch64_clean/src/mlkem_ntt_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED)
/* simpasm: header-end */

Expand Down Expand Up @@ -341,4 +342,5 @@ mlk_ntt_layer4567_start:
.unreq t3

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED */
6 changes: 4 additions & 2 deletions dev/aarch64_clean/src/mlkem_poly_mulcache_compute_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED)
/* simpasm: header-end */

Expand Down Expand Up @@ -129,4 +130,5 @@ mlk_poly_mulcache_compute_loop_start:
.unreq modulus_twisted

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED */
6 changes: 4 additions & 2 deletions dev/aarch64_clean/src/mlkem_poly_reduce_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED)
/* simpasm: header-end */

Expand Down Expand Up @@ -106,4 +107,5 @@ mlk_poly_reduce_loop_start:
.unreq modulus_twisted

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED */
8 changes: 5 additions & 3 deletions dev/aarch64_clean/src/mlkem_poly_tobytes_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && \
(!defined(MLK_CONFIG_NO_KEYPAIR_API) || \
!defined(MLK_CONFIG_NO_ENCAPS_API))
Expand Down Expand Up @@ -96,5 +97,6 @@ mlk_poly_tobytes_loop_start:
.unreq count

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
(!MLK_CONFIG_NO_KEYPAIR_API || !MLK_CONFIG_NO_ENCAPS_API) */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && (!MLK_CONFIG_NO_KEYPAIR_API || \
!MLK_CONFIG_NO_ENCAPS_API) */
7 changes: 4 additions & 3 deletions dev/aarch64_clean/src/mlkem_poly_tomont_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && \
!defined(MLK_CONFIG_NO_KEYPAIR_API)
/* simpasm: header-end */
Expand Down Expand Up @@ -104,5 +105,5 @@ mlk_poly_tomont_loop:
.unreq tmp0

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
!MLK_CONFIG_NO_KEYPAIR_API */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && !MLK_CONFIG_NO_KEYPAIR_API */
6 changes: 4 additions & 2 deletions dev/aarch64_clean/src/mlkem_polyvec_basemul_acc_montgomery_cached_k2_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
/* Re-implementation of asymmetric base multiplication following @[NeonNTT] */

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && \
(defined(MLK_CONFIG_MULTILEVEL_WITH_SHARED) || MLKEM_K == 2)
/* simpasm: header-end */
Expand Down Expand Up @@ -256,5 +257,6 @@ mlk_polyvec_basemul_acc_montgomery_cached_k2_loop_start:

/* simpasm: footer-start */

#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && \
(MLK_CONFIG_MULTILEVEL_WITH_SHARED || MLKEM_K == 2) */
6 changes: 4 additions & 2 deletions dev/aarch64_clean/src/mlkem_polyvec_basemul_acc_montgomery_cached_k3_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
/* Re-implementation of asymmetric base multiplication following @[NeonNTT] */

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && \
(defined(MLK_CONFIG_MULTILEVEL_WITH_SHARED) || MLKEM_K == 3)
/* simpasm: header-end */
Expand Down Expand Up @@ -259,5 +260,6 @@ mlk_polyvec_basemul_acc_montgomery_cached_k3_loop_start:
.unreq t0

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && \
(MLK_CONFIG_MULTILEVEL_WITH_SHARED || MLKEM_K == 3) */
6 changes: 4 additions & 2 deletions dev/aarch64_clean/src/mlkem_polyvec_basemul_acc_montgomery_cached_k4_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
/* Re-implementation of asymmetric base multiplication following @[NeonNTT] */

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && \
(defined(MLK_CONFIG_MULTILEVEL_WITH_SHARED) || MLKEM_K == 4)
/* simpasm: header-end */
Expand Down Expand Up @@ -269,5 +270,6 @@ mlk_polyvec_basemul_acc_montgomery_cached_k4_loop_start:
.unreq t0

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && \
(MLK_CONFIG_MULTILEVEL_WITH_SHARED || MLKEM_K == 4) */
6 changes: 4 additions & 2 deletions dev/aarch64_clean/src/mlkem_rej_uniform_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED)
/* simpasm: header-end */

Expand Down Expand Up @@ -461,4 +462,5 @@ mlk_rej_uniform_return:
#undef STACK_SIZE

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED */
8 changes: 5 additions & 3 deletions dev/aarch64_opt/src/mlkem_intt_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && \
(!defined(MLK_CONFIG_NO_ENCAPS_API) || \
!defined(MLK_CONFIG_NO_DECAPS_API))
Expand Down Expand Up @@ -1423,5 +1424,6 @@ mlk_intt_layer123_start:
.unreq ninv_tw

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
(!MLK_CONFIG_NO_ENCAPS_API || !MLK_CONFIG_NO_DECAPS_API) */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && (!MLK_CONFIG_NO_ENCAPS_API || \
!MLK_CONFIG_NO_DECAPS_API) */
6 changes: 4 additions & 2 deletions dev/aarch64_opt/src/mlkem_ntt_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED)
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED)
/* simpasm: header-end */

// Bounds:
Expand Down Expand Up @@ -1270,4 +1271,5 @@ mlk_ntt_layer4567_start:
.unreq t3

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED */
6 changes: 4 additions & 2 deletions dev/aarch64_opt/src/mlkem_poly_mulcache_compute_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED)
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED)
/* simpasm: header-end */

/* Montgomery multiplication, with precomputed Montgomery twist
Expand Down Expand Up @@ -279,4 +280,5 @@ mlk_poly_mulcache_compute_loop_start:
.unreq modulus_twisted

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED */
6 changes: 4 additions & 2 deletions dev/aarch64_opt/src/mlkem_poly_reduce_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED)
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED)
/* simpasm: header-end */

/* Barrett reduction */
Expand Down Expand Up @@ -332,4 +333,5 @@ mlk_poly_reduce_loop_start:
.unreq modulus_twisted

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED */
8 changes: 5 additions & 3 deletions dev/aarch64_opt/src/mlkem_poly_tobytes_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && \
(!defined(MLK_CONFIG_NO_KEYPAIR_API) || \
!defined(MLK_CONFIG_NO_ENCAPS_API))
Expand Down Expand Up @@ -256,5 +257,6 @@ mlk_poly_tobytes_loop_start:
.unreq count

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
(!MLK_CONFIG_NO_KEYPAIR_API || !MLK_CONFIG_NO_ENCAPS_API) */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && (!MLK_CONFIG_NO_KEYPAIR_API || \
!MLK_CONFIG_NO_ENCAPS_API) */
7 changes: 4 additions & 3 deletions dev/aarch64_opt/src/mlkem_poly_tomont_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && \
!defined(MLK_CONFIG_NO_KEYPAIR_API)
/* simpasm: header-end */
Expand Down Expand Up @@ -222,5 +223,5 @@ mlk_poly_tomont_loop:
.unreq tmp0

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
!MLK_CONFIG_NO_KEYPAIR_API */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && !MLK_CONFIG_NO_KEYPAIR_API */
6 changes: 4 additions & 2 deletions dev/aarch64_opt/src/mlkem_polyvec_basemul_acc_montgomery_cached_k2_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
/* Re-implementation of asymmetric base multiplication following @[NeonNTT] */

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && (defined(MLK_CONFIG_MULTILEVEL_WITH_SHARED) || MLKEM_K == 2)
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && (defined(MLK_CONFIG_MULTILEVEL_WITH_SHARED) || MLKEM_K == 2)
/* simpasm: header-end */

// Input:
Expand Down Expand Up @@ -586,5 +587,6 @@ mlk_polyvec_basemul_acc_montgomery_cached_k2_loop_start:

/* simpasm: footer-start */

#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && \
(MLK_CONFIG_MULTILEVEL_WITH_SHARED || MLKEM_K == 2) */
6 changes: 4 additions & 2 deletions dev/aarch64_opt/src/mlkem_polyvec_basemul_acc_montgomery_cached_k3_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
/* Re-implementation of asymmetric base multiplication following @[NeonNTT] */

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && (defined(MLK_CONFIG_MULTILEVEL_WITH_SHARED) || MLKEM_K == 3)
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && (defined(MLK_CONFIG_MULTILEVEL_WITH_SHARED) || MLKEM_K == 3)
/* simpasm: header-end */

// Input:
Expand Down Expand Up @@ -689,5 +690,6 @@ mlk_polyvec_basemul_acc_montgomery_cached_k3_loop_start:
.unreq t0

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && \
(MLK_CONFIG_MULTILEVEL_WITH_SHARED || MLKEM_K == 3) */
6 changes: 4 additions & 2 deletions dev/aarch64_opt/src/mlkem_polyvec_basemul_acc_montgomery_cached_k4_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
/* Re-implementation of asymmetric base multiplication following @[NeonNTT] */

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && (defined(MLK_CONFIG_MULTILEVEL_WITH_SHARED) || MLKEM_K == 4)
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && !defined(MLK_CONFIG_MULTILEVEL_NO_SHARED) && (defined(MLK_CONFIG_MULTILEVEL_WITH_SHARED) || MLKEM_K == 4)
/* simpasm: header-end */

// Input:
Expand Down Expand Up @@ -799,5 +800,6 @@ mlk_polyvec_basemul_acc_montgomery_cached_k4_loop_start:
.unreq t0

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED && \
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED && \
(MLK_CONFIG_MULTILEVEL_WITH_SHARED || MLKEM_K == 4) */
6 changes: 4 additions & 2 deletions dev/aarch64_opt/src/mlkem_rej_uniform_aarch64_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
*/

#include "../../../common.h"
#if defined(MLK_ARITH_BACKEND_AARCH64) && \
#if defined(MLK_SYS_AARCH64_NEON) && \
defined(MLK_ARITH_BACKEND_AARCH64) && \
!defined(MLK_CONFIG_MULTILEVEL_NO_SHARED)
/* simpasm: header-end */

Expand Down Expand Up @@ -461,4 +462,5 @@ mlk_rej_uniform_return:
#undef STACK_SIZE

/* simpasm: footer-start */
#endif /* MLK_ARITH_BACKEND_AARCH64 && !MLK_CONFIG_MULTILEVEL_NO_SHARED */
#endif /* MLK_SYS_AARCH64_NEON && MLK_ARITH_BACKEND_AARCH64 && \
!MLK_CONFIG_MULTILEVEL_NO_SHARED */
Loading
Loading