Repository navigation
Doc improvements - #1935
Merged
Merged
Doc improvements#1935
Conversation
Contributor
CBMC Results (ML-KEM-768)
Full Results (195 configurations)
|
Contributor
CBMC Results (ML-KEM-1024)
Full Results (195 configurations)
|
Contributor
CBMC Results (ML-KEM-512)
Full Results (195 configurations)
|
hanno-becker
requested changes
Oct 11, 2026
hanno-becker
left a comment
Contributor
There was a problem hiding this comment.
Those are good findings, but I think we need to do a bit more to either address or appropriately document the limitations.
All public API contracts require their buffers to be disjoint, but this was not documented. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
The C code is only constant-time if multiplications are, which is not the case on all targets. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
The backends for platforms other than AArch64 and x86_64 (e.g. the RVV C code) and the debug code have no CBMC proofs, matching the scope stated in SOUNDNESS.md. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
The valgrind constant-time tests only run on x86_64 and AArch64 in the default configuration. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
mkannwischer
force-pushed
the
doc-improvements
branch
from
October 12, 2026 15:23
ba15401 to
825af92
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 12, 2026
AppelJr
pushed a commit
to AppelJr/mldsa-native
that referenced
this pull request
Oct 16, 2026
State in API-CONVENTIONS.md and mldsa_native.h that buffers passed to the same function must not overlap, document that the C code assumes constant-time 32x32->32 and 32x32->64 multiplication, and exclude the Armv8.1-M backend and the debug code from the CBMC claim in the README, as in mlkem-native. Ports pq-code-package/mlkem-native#1935. The SOUNDNESS.md change is not ported: mldsa-native's SOUNDNESS.md defers to mlkem-native's analysis, which now includes it. - Resolves pq-code-package#1463 Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commit messages.