Repository navigation
mldsa: Clean-up includes - #1481
Open
mkannwischer wants to merge 2 commits into
Open
mkannwischer wants to merge 2 commits into
mkannwischer wants to merge 2 commits into
Conversation
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)
Full Results (226 configurations)
|
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)
Full Results (226 configurations)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)
Full Results (226 configurations)
|
Contributor
CBMC Results (ML-DSA-44)
Full Results (226 configurations)
|
Contributor
CBMC Results (ML-DSA-65)
Full Results (226 configurations)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (226 configurations)
|
mkannwischer
force-pushed
the
include-cleanup
branch
from
October 21, 2026 07:09
7d828f3 to
48681e0
Compare
mkannwischer
marked this pull request as ready for review
October 21, 2026 07:10
hanno-becker
requested changes
Oct 24, 2026
hanno-becker
left a comment
Contributor
There was a problem hiding this comment.
I think 48681e0 is a step back; otherwise LGTM.
hanno-becker
requested changes
Oct 24, 2026
hanno-becker
left a comment
Contributor
There was a problem hiding this comment.
I think it hinders readability to mix stdlib and internal includes and prefer to keep it as is.
clang-format identifies the main include by file name, so formatting a temporary copy with a random name sorted it differently from lint. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Keep the internal includes of library sources in a single block, separated from standard-library includes by a blank line, and drop the unused <string.h> include in the x86_64 backend. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
mkannwischer
force-pushed
the
include-cleanup
branch
from
October 24, 2026 07:01
48681e0 to
67b656d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the concern raised by #1480 (comment). Turns out this was a artifact of how our autogen script worked.