Discover MSVC runtime files during Windows builds - #210
Merged
Merged
Conversation
Hosted runners can change Visual Studio generations and the contents of Microsoft.VC*.CRT. Copy the DLLs the active toolset actually provides, bundle them through a glob, and test VC143- and VC145-shaped layouts so optional runtime changes cannot break packaging again.
The build staging directory keeps redistributable DLLs isolated from sherpa files, while Tauri flattens them in packages. Accept both representations so CI checks the same files before and after packaging.
Pass the NSIS destination switch in its required unquoted form, distinguish bundled MSVC redistributables from the system UCRT, and normalize CRLF manifest entries before Bash size checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.5.0 Windows build failed because its hard-coded VC143 runtime list required
vcamp140.dll, while the current VS2026/VC145 runner no longer ships that optional DLL inMicrosoft.VC145.CRT.Discover and stage every DLL that the active
Microsoft.VC*.CRTdirectory actually contains, validate only Wisp's minimum startup ABI, and bundle the discovered set with a Tauri glob. This remains compatible when hosted runners change Visual Studio generations or optional CRT files.The installer smoke test now verifies every loaded VC++ runtime module comes from the Wisp install directory, not only
msvcp140.dll.Test plan