Audit and update Rust dependencies - #213
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
The sarif upload appears to have failed:
It would be good to see what it looks like when results are uploaded. I see the same vulnerability is also picked up here: https://github.com/powersync-ja/powersync-sqlite-core/security/dependabot/4. I assume this does essentially the same thing, but on the pruned dependency tree from #212? |
Yes. I wasn't aware of the existing analysis, I think it's still helpful to fail the build if a vulnerability is found in code we end up shipping though.
I think this is an unfortunate effect of the scanning action failing the build without emitting the sarif file. I'll see if we can invoke the scanner twice, once to generate the report and once to fail the build. |
2d14342 to
a0c2f1c
Compare
|
Ok, the actual cause of the upload failure is that generated sarif files only contain the message but no source location for which GitHub could show an alert. That's unfortunate, I've switched to failing the build and showing a table of found issues now. |
This is a small follow-up to #212, which introduced SBOMs for core extension binaries.
This PR:
serde_withversion we use, this updates Rust dependencies throughcargo update. We're not affected by that issue.