Repository navigation
Add terminal focus shortcut and input focus highlight - #421
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7070ad97f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
When another control takes keyboard focus, users cannot tell whether the terminal still accepts input or return to it without clicking. Add a configurable
Ctrl+Backquoteshortcut that returns focus to the current terminal, or its open Composer draft, and reveals the terminal when another workspace surface is open.Use a bright accent border and glow for actual input focus in single-pane, split, zoomed, and Zen layouts. Keep a muted selection border on the active split pane after input focus moves elsewhere. Existing custom shortcut assignments survive the addition of the new action.
Terminal focus uses the existing input activation path before focusing xterm, including on touch-capable devices using the desktop layout. The React/xterm regression harness covers direct input after touch, Composer, and disconnected, paused, and inactive-pane safety.
Validation
bun run precommit— formatting, lint, type checks, frontend build and asset budgets, and the complete test suite: 3,704 passed, 4 skipped.bun run build:web— passed.Limitations