Skip to content

Add folder creation and multi-file drag moves - #418

Merged
powerfooI merged 4 commits into
mainfrom
files-panel-menu
Oct 15, 2026
Merged

powerfooI merged 4 commits into
mainfrom
files-panel-menu

Conversation

@powerfooI

@powerfooI powerfooI commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

The Files pane now supports creating folders from the toolbar or a folder's actions menu, selecting multiple files with Cmd/Ctrl-click or Shift-click, and dragging them into a folder or back to the checkout root. Smaller toolbar buttons stay grouped on one row, and right-clicking the background offers New folder and Refresh files.

Moves use atomic exclusive renames on local hosts and Linux/macOS SSH hosts, preserving concurrent saves and existing destination entries. Batch moves and their directory refreshes run sequentially to avoid exhausting SSH connection limits; partial failures leave the failed files selected. Regression coverage includes POSIX filename handling, permissions and retry, conflicts, symlink confinement, preview cache invalidation, selection, context menus, duplicate folder submissions, and Escape handling after focus loss.

Validation:

  • bun run precommit through the installed commit hook: formatting, lint, full type checks, frontend build, and the complete test suite (3,691 passed, 4 skipped, 0 failed).
  • bun test server/src/workspace/file-mutations.test.ts web/src/components/FileExplorerDialog.dom.test.ts web/src/components/ModalDialogs.test.ts: 30 passed.
  • Native atomic-move checks passed on macOS, Linux, and Windows ARM64; a Linux SSH smoke test covered folder creation, conflicts, read-only source failure, and retry.

Moves require the source and destination to be on the same filesystem. SSH moves require Python 3 and a supported atomic rename primitive; unsupported operations fail without a copy/delete fallback. Real-browser drag and final layout verification could not be completed because browser automation was unavailable.

@powerfooI powerfooI added the enhancement New feature or request label Oct 15, 2026
@powerfooI

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T03:23:56.009985Z 9be426c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9f36b8f28

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/src/components/FileExplorerDialog.tsx
@powerfooI

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a2e1a48b3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/src/components/FileExplorerDialog.tsx Outdated
@powerfooI

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6814719cf0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/src/components/FileExplorerDialog.tsx
Comment thread server/src/workspace/file-paths.ts
@powerfooI

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 9be426c1d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@powerfooI
powerfooI merged commit 589b059 into main Oct 15, 2026
5 checks passed
@powerfooI
powerfooI deleted the files-panel-menu branch October 15, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant