Repository navigation
Pin managed Herdr installations to 0.9.4 - #414
Merged
Merged
Conversation
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managed Herdr setup now pins 0.9.4 and its five official SHA-256 values. Protocol 22 and endpoint generation 1 remain unchanged. The Windows installer regression checks that the new versioned directory preserves an existing 0.9.0 installation; CLI fixtures and compatibility guidance follow the new baseline. Existing running servers and binaries on PATH are not upgraded automatically.
Refs #411; follows merged #412 and #413. The maintainer requested merging the installer baseline after a clean Codex review and passing checks. The browser and real-agent acceptance checks below remain outstanding in #411. This does not publish a Roamgate release.
Verification
bun run precommit: format, lint, web build, TypeScript checks and the full suite passed; 3553 passed, 3 opt-in platform/live tests skipped.bun run typecheck:bun: passed for all three TypeScript projects.latest.jsonSHA-256 table and GitHub release asset digests. Verified the Windows archive includesherdr.exe, ConPTY DLL, x64 and ARM64 OpenConsole helpers, metadata and notices; real Windows extraction and server startup succeeded.0x8664Each row passed an isolated smoke test using Roamgate's actual HerdrClient and EndpointClient: RPC protocol 22, event subscription, generation 1 attach, rendered surface, semantic text/Enter input, pane.read, resize, tab/workspace creation, endpoint reconnect, and passive notification attachment. These are headless transport checks, not browser rendering acceptance.
server/src/connections/windows-ssh-live.test.tsran against two disposable Windows profiles/sessions: 2 passed, including PowerShell/Unicode input, resize, disconnect/reconnect, and session/generation isolation.Remaining #411 acceptance checks
cgWindowNotFound.Native x64 hardware was not tested; x64 results above are explicitly emulated. Herdr publishes no native Windows ARM64 asset, and managed setup still rejects that target. No packages, persistent services, firewall rules or permission policies were changed in the guests. Test binaries/configs/sessions were isolated from installed Herdr. Local commands and logs are under
/tmp/roamgate-411/; guest test files and temporary servers are removed after verification, with Windows returned to suspended and Ubuntu to stopped.