Repository navigation
Conversation
A labeled transition such as `a --> b : text` is valid Mermaid stateDiagram-v2 syntax, but parse_mmd stored `b : text` as the target state. The flow then failed with a false "no path to [*]" error. Strip the label from the transition target. Fixes #232 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pre-push checklist ratchet. No existing violations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #232
Problem
A
flow.mmdwith a transition label (a --> b : text) failed to load withstate 'a' has no path to [*].parse_mmdsplit the line on-->and storedb : textas the target state. Transition labels are valid MermaidstateDiagram-v2syntax.Change
core/src/flow.rs:split_transitiondrops the: labelsuffix from the transition target.core/src/flow_tests.rs: newignores_transition_labelstest (labeled branch + labeled terminal transition).CHANGELOG.md: entry under Unreleased.core/Cargo.toml: denyclippy::explicit_into_iter_loop. The repo's pre-push checklist requires one lint ratchet per push. This lint has no violations, so the change is one line.Verification
cargo test,cargo clippy --all-targets -- -D warnings,cargo fmt --checkandcargo docwith-D warningspass.tests --> docs : yes/tests --> fix : nonow validates. The hook blocks on each state, follows thefixbranch onack.sh fix, and approves after the last ack. Publishedsteplock 0.2.2rejects the same flow.Opened by the moadim routine "Nightly lib dogfood → issue + PR (polyhook, block-no-verify, steplock)".
🤖 Generated with Claude Code